chore: fix spark ansi sum incompatibility message#4111
Open
coderfender wants to merge 8 commits into
Open
Conversation
coderfender
commented
Apr 28, 2026
coderfender
commented
Apr 28, 2026
coderfender
force-pushed
the
fix_comet_sum_compatbility_level
branch
from
0d481f4 to
2fdb835
Compare
coderfender
commented
Apr 29, 2026
coderfender
commented
Apr 29, 2026
coderfender
commented
Apr 29, 2026
coderfender
commented
Apr 29, 2026
coderfender
commented
Apr 29, 2026
Contributor
Author
coderfender
left a comment
coderfender
left a comment
There was a problem hiding this comment.
added some comments to help with review
andygrove
reviewed
Apr 29, 2026
andygrove
reviewed
Apr 29, 2026
andygrove
reviewed
May 5, 2026
| object CometStringRepeat extends CometExpressionSerde[StringRepeat] { | ||
|
|
||
| override def getCompatibleNotes(): Seq[String] = Seq( | ||
| override def getIncompatibleReasons(): Seq[String] = Seq( |
Member
There was a problem hiding this comment.
getIncompatibleReasons needs to be removed now that this issue has been fixed in #4017
Member
There was a problem hiding this comment.
Actually that was the wrong issue ... why does this PR rename this method? There is no getSupportLevel so this expression is not marked as incompatible
Contributor
Author
There was a problem hiding this comment.
True ! Thank you for pointing this out. I fixed it in the latest commit
Member
There was a problem hiding this comment.
some comments got lost I think due to GitHub outages ... I don't understand why this PR is removing getCompatibleNotes and adding getIncompatibleReasons
andygrove
reviewed
May 5, 2026
andygrove
reviewed
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4074
Rationale for this change
What changes are included in this PR?
How are these changes tested?